codope commented on a change in pull request #4253:
URL: https://github.com/apache/hudi/pull/4253#discussion_r765408801
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowParquetWriteSupport.java
##########
@@ -46,13 +53,32 @@
public HoodieRowParquetWriteSupport(Configuration conf, StructType
structType, BloomFilter bloomFilter, HoodieWriteConfig writeConfig) {
super();
Configuration hadoopConf = new Configuration(conf);
- hadoopConf.set("spark.sql.parquet.writeLegacyFormat",
writeConfig.parquetWriteLegacyFormatEnabled());
+ hadoopConf.set("spark.sql.parquet.writeLegacyFormat",
findSmallPrecisionDecimalType(structType) ? "true" :
writeConfig.parquetWriteLegacyFormatEnabled());
Review comment:
If `findSmallPrecisionDecimalType` returns false and
`parquetWriteLegacyFormatEnabled` is set to true in the config then
`spark.sql.parquet.writeLegacyFormat` will be true. Is that the intention?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
