alexeykudinkin commented on a change in pull request #4020:
URL: https://github.com/apache/hudi/pull/4020#discussion_r766131746
##########
File path:
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileReader.java
##########
@@ -170,19 +175,19 @@ public BloomFilter readBloomFilter() {
}
public List<Pair<String, R>> readAllRecords() throws IOException {
- Schema schema = new Schema.Parser().parse(new
String(reader.loadFileInfo().get(KEY_SCHEMA.getBytes())));
+ Schema schema = new Schema.Parser().parse(new
String(reader.getHFileInfo().get(KEY_SCHEMA.getBytes())));
return readAllRecords(schema, schema);
}
public List<Pair<String, R>> readRecords(List<String> keys) throws
IOException {
- reader.loadFileInfo();
- Schema schema = new Schema.Parser().parse(new
String(reader.loadFileInfo().get(KEY_SCHEMA.getBytes())));
+ reader.getHFileInfo();
Review comment:
Why are we doing this here?
##########
File path: packaging/hudi-hadoop-mr-bundle/pom.xml
##########
@@ -202,5 +216,35 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.hbase</groupId>
+ <artifactId>hbase-client</artifactId>
+ <version>${hbase.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hbase</groupId>
+ <artifactId>hbase-protocol-shaded</artifactId>
+ <version>${hbase.version}</version>
Review comment:
Shouldn't this be `hbase.shaded.version`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
