minihippo commented on a change in pull request #3173:
URL: https://github.com/apache/hudi/pull/3173#discussion_r769782126
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java
##########
@@ -540,5 +602,28 @@ private String getDefaultIndexType(EngineType engineType) {
public EngineType getEngineType() {
return engineType;
}
+
+ private void validateBucketIndexConfig() {
+ if (hoodieIndexConfig.getString(INDEX_TYPE)
+ .equalsIgnoreCase(HoodieIndex.IndexType.BUCKET_INDEX.toString())) {
+ // check the bucket index hash field
+ if
(StringUtils.isNullOrEmpty(hoodieIndexConfig.getString(BUCKET_INDEX_HASH_FIELD)))
{
Review comment:
I check that we set KeyGeneratorOptions.RECORDKEY_FIELD_NAME across all
code paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
