nsivabalan commented on a change in pull request #4342:
URL: https://github.com/apache/hudi/pull/4342#discussion_r770610829



##########
File path: 
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -229,7 +229,11 @@ object HoodieSparkSqlWriter {
             }
             sparkContext.getConf.registerAvroSchemas(schema)
             log.info(s"Registered avro schema : ${schema.toString(true)}")
-
+            val columnSet = df.columns.toSet
+            keyGenerator.getRecordKeyFieldNames.foreach(fieldName => 
if(!columnSet.contains(fieldName)) {
+              throw new Exception(s"record key '$fieldName' does not exist in 
existing table schema :  ${schema.toString(true)}")

Review comment:
       Is code style all good? guess L235 should be intended. Did you apply the 
code style format as per the guidelines? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to