yihua commented on a change in pull request #4078:
URL: https://github.com/apache/hudi/pull/4078#discussion_r770868447
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java
##########
@@ -249,6 +249,19 @@
+ "record size estimate compute dynamically based on commit
metadata. "
+ " This is critical in computing the insert parallelism and
bin-packing inserts into small files.");
+ public static final ConfigProperty<String> MAX_ARCHIVE_FILES_TO_KEEP_PROP =
ConfigProperty
+ .key("hoodie.max.archive.files")
+ .defaultValue("10")
+ .withDocumentation("The numbers of kept archive files under archived.");
+
+ public static final ConfigProperty<String> AUTO_TRIM_ARCHIVE_FILES_DROP =
ConfigProperty
+ .key("hoodie.auto.trim.archive.files")
+ .defaultValue("false")
+ .withDocumentation("When enabled, Hoodie will keep the most recent " +
MAX_ARCHIVE_FILES_TO_KEEP_PROP.key()
+ + " archive files and delete older one which lose part of archived
instants information.");
Review comment:
Got it. Ideally, the archive configs should not be in
`HoodieCompactionConfig`. Let's keep it as is for now and clean this up in a
follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
