nsivabalan commented on a change in pull request #4363:
URL: https://github.com/apache/hudi/pull/4363#discussion_r771831912
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/restore/BaseRestoreActionExecutor.java
##########
@@ -112,7 +112,7 @@ private void writeToMetadata(HoodieRestoreMetadata
restoreMetadata) {
this.txnManager.beginTransaction(Option.empty(), Option.empty());
writeTableMetadata(restoreMetadata);
} finally {
- this.txnManager.endTransaction();
+ this.txnManager.endTransaction(Option.empty());
Review comment:
can we try to see if we can set atleast current owner at L 112.
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java
##########
@@ -266,7 +266,7 @@ protected void finishRollback(HoodieInstant
inflightInstant, HoodieRollbackMetad
throw new HoodieIOException("Error executing rollback at instant " +
instantTime, e);
} finally {
if (!skipLocking) {
- this.txnManager.endTransaction();
+ this.txnManager.endTransaction(Option.empty());
Review comment:
Guess we can fix L259 to send atleast the current trxn owner. may be
last can be empty.
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java
##########
@@ -217,7 +217,7 @@ private HoodieCleanMetadata runClean(HoodieTable<T, I, K,
O> table, HoodieInstan
throw new HoodieIOException("Failed to clean up after commit", e);
} finally {
if (!skipLocking) {
- this.txnManager.endTransaction();
+ this.txnManager.endTransaction(Option.empty());
Review comment:
can we try to set current trxn at L209. last trxn can be empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
