xushiyan commented on a change in pull request #4398:
URL: https://github.com/apache/hudi/pull/4398#discussion_r772796740
##########
File path: pom.xml
##########
@@ -316,19 +316,6 @@
</execution>
</executions>
</plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-surefire-plugin</artifactId>
- <version>${maven-surefire-plugin.version}</version>
- <configuration>
- <argLine>@{argLine}</argLine>
- <systemPropertyVariables>
- <log4j.configuration>
- ${surefire-log4j.file}
- </log4j.configuration>
- </systemPropertyVariables>
- </configuration>
- </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
Review comment:
does it also make sense to move failsafe to plugin management too?
##########
File path: pom.xml
##########
@@ -355,6 +342,20 @@
<pluginManagement>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>${maven-surefire-plugin.version}</version>
+ <configuration>
+ <rerunFailingTestsCount>3</rerunFailingTestsCount>
Review comment:
unfortunately the website says only for junit 4.x
https://maven.apache.org/surefire/maven-surefire-plugin/examples/rerun-failing-tests.html
have you tried it and seen it working?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
