nsivabalan commented on a change in pull request #4413:
URL: https://github.com/apache/hudi/pull/4413#discussion_r773511174



##########
File path: 
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSource.java
##########
@@ -110,6 +113,9 @@ public S3EventsHoodieIncrSource(
     if (!StringUtils.isNullOrEmpty(props.getString(Config.S3_KEY_PREFIX))) {
       filter = filter + " and s3.object.key like '" + 
props.getString(Config.S3_KEY_PREFIX) + "%'";
     }
+    if 
(!StringUtils.isNullOrEmpty(props.getString(Config.S3_IGNORE_KEY_PREFIX))) {

Review comment:
       apparently S3 incremental source does not have good tests. I have filed 
a tracking jira [here](https://issues.apache.org/jira/browse/HUDI-3089). Will 
take it as a follow up. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to