nsivabalan commented on a change in pull request #4212:
URL: https://github.com/apache/hudi/pull/4212#discussion_r773560834
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -708,15 +708,25 @@ public HoodieCleanMetadata clean(String cleanInstantTime,
boolean skipLocking) t
* @param skipLocking if this is triggered by another parent transaction,
locking can be skipped.
*/
public HoodieCleanMetadata clean(String cleanInstantTime, boolean
scheduleInline, boolean skipLocking) throws HoodieIOException {
- if (scheduleInline) {
- scheduleTableServiceInternal(cleanInstantTime, Option.empty(),
TableServiceType.CLEAN);
- }
LOG.info("Cleaner started");
final Timer.Context timerContext = metrics.getCleanCtx();
LOG.info("Cleaned failed attempts if any");
CleanerUtils.rollbackFailedWrites(config.getFailedWritesCleanPolicy(),
HoodieTimeline.CLEAN_ACTION, () -> rollbackFailedWrites(skipLocking));
- HoodieCleanMetadata metadata = createTable(config,
hadoopConf).clean(context, cleanInstantTime, skipLocking);
+
+ // If there are pending clean operations, attempt them before scheduling
the next clean. This prevents the
+ // next clean from deciding to clean the same files which might be under
clean from pending operations.
+ HoodieCleanMetadata metadata = null;
+ HoodieTable table = createTable(config, hadoopConf);
Review comment:
yeah, I also feel the planner should ensure that clean plans are
mutually exclusive. If there is a pending cleaning, it will eventually succeed.
So, may be we can assume (for the most cases) once a clean plan is generated,
it will get completed. Even on failure, it will get re-attempted right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
