dongkelun commented on a change in pull request #4016:
URL: https://github.com/apache/hudi/pull/4016#discussion_r774269869
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java
##########
@@ -230,11 +230,15 @@ public HoodieCleanMetadata execute() {
.filterInflightsAndRequested().getInstants().collect(Collectors.toList());
if (pendingCleanInstants.size() > 0) {
pendingCleanInstants.forEach(hoodieInstant -> {
- LOG.info("Finishing previously unfinished cleaner instant=" +
hoodieInstant);
- try {
- cleanMetadataList.add(runPendingClean(table, hoodieInstant));
- } catch (Exception e) {
- LOG.warn("Failed to perform previous clean operation, instant: " +
hoodieInstant, e);
+ if (table.getCleanTimeline().isEmpty(hoodieInstant)) {
Review comment:
I think it should be, but at present, we do encounter the problem of
empty files in many cases, as well as in the test cases of PR run I submitted
earlier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
