leesf commented on a change in pull request #4436:
URL: https://github.com/apache/hudi/pull/4436#discussion_r775029303
##########
File path:
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTableDropPartition.scala
##########
@@ -172,4 +226,51 @@ class TestAlterTableDropPartition extends
TestHoodieSqlBase {
}
}
}
+
+ Seq(false, true).foreach { hiveStyle =>
+ test(s"Purge drop multi-level partitioned table's partitions,
isHiveStylePartitioning: $hiveStyle") {
Review comment:
would you please also add a test about drop partition purge for
non-partitioned table?
##########
File path:
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTableDropPartition.scala
##########
@@ -172,4 +226,51 @@ class TestAlterTableDropPartition extends
TestHoodieSqlBase {
}
}
}
+
+ Seq(false, true).foreach { hiveStyle =>
+ test(s"Purge drop multi-level partitioned table's partitions,
isHiveStylePartitioning: $hiveStyle") {
Review comment:
would you please also add a test about dropping partition purge for
non-partitioned table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
