leesf commented on a change in pull request #4436:
URL: https://github.com/apache/hudi/pull/4436#discussion_r775466310
##########
File path:
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTableDropPartition.scala
##########
@@ -172,4 +250,51 @@ class TestAlterTableDropPartition extends
TestHoodieSqlBase {
}
}
}
+
+ Seq(false, true).foreach { hiveStyle =>
+ test(s"Purge drop multi-level partitioned table's partitions,
isHiveStylePartitioning: $hiveStyle") {
+ withTempDir { tmp =>
+ val tableName = generateTableName
+ val tablePath = s"${tmp.getCanonicalPath}/$tableName"
+
+ import spark.implicits._
+ val df = Seq((1, "z3", "v1", "2021", "10", "01"), (2, "l4", "v1",
"2021", "10","02"))
+ .toDF("id", "name", "ts", "year", "month", "day")
+
+ df.write.format("hudi")
+ .option(HoodieWriteConfig.TBL_NAME.key, tableName)
+ .option(TABLE_TYPE.key, COW_TABLE_TYPE_OPT_VAL)
+ .option(RECORDKEY_FIELD.key, "id")
+ .option(PRECOMBINE_FIELD.key, "ts")
+ .option(PARTITIONPATH_FIELD.key, "year,month,day")
+ .option(HIVE_STYLE_PARTITIONING.key, hiveStyle)
+ .option(KEYGENERATOR_CLASS_NAME.key,
classOf[ComplexKeyGenerator].getName)
+ .option(HoodieWriteConfig.INSERT_PARALLELISM_VALUE.key, "1")
+ .option(HoodieWriteConfig.UPSERT_PARALLELISM_VALUE.key, "1")
+ .mode(SaveMode.Overwrite)
+ .save(tablePath)
+
+ // register meta to spark catalog by creating table
+ spark.sql(
+ s"""
+ |create table $tableName using hudi
+ |tblproperties (
+ | primaryKey = 'id',
+ | preCombineField = 'ts'
+ |)
+ |partitioned by (year, month, day)
+ |location '$tablePath'
+ |""".stripMargin)
+
+ // drop 2021-10-01 partition
+ spark.sql(s"alter table $tableName drop partition (year='2021',
month='10', day='01') purge")
+
+ checkAnswer(s"select id, name, ts, year, month, day from $tableName")(
+ Seq(2, "l4", "v1", "2021", "10", "02")
+ )
+ assertResult(false)(existsPath(
+
s"${tmp.getCanonicalPath}/$tableName/year='2021'/month='10'/day='01'"))
Review comment:
why here is not
${tmp.getCanonicalPath}/$tableName/year=2021/month=10/day=01
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
