minihippo commented on a change in pull request #3173:
URL: https://github.com/apache/hudi/pull/3173#discussion_r775530270
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BaseSparkCommitActionExecutor.java
##########
@@ -303,7 +305,7 @@ protected void commit(Option<Map<String, String>>
extraMetadata, HoodieWriteMeta
@SuppressWarnings("unchecked")
protected Iterator<List<WriteStatus>> handleUpsertPartition(String
instantTime, Integer partition, Iterator recordItr,
Partitioner
partitioner) {
- UpsertPartitioner upsertPartitioner = (UpsertPartitioner) partitioner;
+ SparkHoodiePartitioner upsertPartitioner = (SparkHoodiePartitioner)
partitioner;
Review comment:
Introduce a `SparkHoodiePartitioner` to implements both spark
partitioner and hudi partitioner which is to get bucket info. The
`UpsertPartitioner` inherit it.
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BaseSparkCommitActionExecutor.java
##########
@@ -303,7 +305,7 @@ protected void commit(Option<Map<String, String>>
extraMetadata, HoodieWriteMeta
@SuppressWarnings("unchecked")
protected Iterator<List<WriteStatus>> handleUpsertPartition(String
instantTime, Integer partition, Iterator recordItr,
Partitioner
partitioner) {
- UpsertPartitioner upsertPartitioner = (UpsertPartitioner) partitioner;
+ SparkHoodiePartitioner upsertPartitioner = (SparkHoodiePartitioner)
partitioner;
Review comment:
Introduce a `SparkHoodiePartitioner` to implements both spark
partitioner and hudi partitioner which is to get bucket info. The
`UpsertPartitioner` inherits it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
