xushiyan commented on a change in pull request #4452:
URL: https://github.com/apache/hudi/pull/4452#discussion_r775699815
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
##########
@@ -169,25 +168,24 @@ protected void syncHoodieTable(String tableName, boolean
useRealtimeInputFormat,
boolean isDropPartition = hoodieHiveClient.isDropPartition();
// check if schemaChanged
- boolean schemaChanged = false;
-
- if (!isDropPartition) {
- // Get the parquet schema for this table looking at the latest commit
- MessageType schema = hoodieHiveClient.getDataSchema();
-
- // Currently HoodieBootstrapRelation does support reading bootstrap MOR
rt table,
- // so we disable the syncAsSparkDataSourceTable here to avoid read such
kind table
- // by the data source way (which will use the HoodieBootstrapRelation).
- // TODO after we support bootstrap MOR rt table in
HoodieBootstrapRelation[HUDI-2071], we can remove this logical.
- if (hoodieHiveClient.isBootstrap()
- && hoodieHiveClient.getTableType() == HoodieTableType.MERGE_ON_READ
- && !readAsOptimized) {
- cfg.syncAsSparkDataSourceTable = false;
- }
- // Sync schema if needed
- schemaChanged = syncSchema(tableName, tableExists,
useRealtimeInputFormat, readAsOptimized, schema);
+ boolean schemaChanged;
Review comment:
this declaration is redundant now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
