zhangyue19921010 commented on pull request #3897: URL: https://github.com/apache/hudi/pull/3897#issuecomment-1001894159
> @zhangyue19921010 thanks for the patch. Can you explain what is the downside of keep the logic as is? in another word: even if auto clean disabled, why wouldn't you increase min instants to keep to be greater than commits retained? Hi @xushiyan Thanks a lot for your attention. Actually this is a minor patch, and just make hudi‘s behavior maybe more appropriate. If I must point a downside, it maybe trouble users who are doing or and writing UTs for archival which need to take care of the min-instants/commits-retained even they disable auto clean :) Just nit patch here I had to say. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
