zhangyue19921010 commented on a change in pull request #4453:
URL: https://github.com/apache/hudi/pull/4453#discussion_r775797895
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/JDBCExecutor.java
##########
@@ -144,9 +147,49 @@ private String getHiveJdbcUrlWithDefaultDBName(String
jdbcUrl) {
@Override
public void dropPartitionsToTable(String tableName, List<String>
partitionsToDrop) {
- partitionsToDrop.stream()
- .map(partition -> String.format("ALTER TABLE `%s` DROP PARTITION
(%s)", tableName, partition))
- .forEach(this::runSQL);
+ if (partitionsToDrop.isEmpty()) {
+ LOG.info("No partitions to add for " + tableName);
+ return;
+ }
+ LOG.info("Adding partitions " + partitionsToDrop.size() + " to table " +
tableName);
+ List<String> sqls = constructDropPartitions(tableName, partitionsToDrop);
+ sqls.stream().forEach(sql -> runSQL(sql));
+ }
+
+ private List<String> constructDropPartitions(String tableName, List<String>
partitions) {
+ if (config.batchSyncNum <= 0) {
+ throw new HoodieHiveSyncException("batch-sync-num for sync hive table
must be greater than 0, pls check your parameter");
+ }
+ List<String> result = new ArrayList<>();
+ int batchSyncPartitionNum = config.batchSyncNum;
+ StringBuilder alterSQL = getAlterTableDropPrefix(tableName);
+
+ for (int i = 0; i < partitions.size(); i++) {
+ String partitionClause = getPartitionClause(partitions.get(i));
+ if (i == 0) {
+ alterSQL.append(" PARTITION (").append(partitionClause).append(")");
+ } else {
+ alterSQL.append(", PARTITION (").append(partitionClause).append(")");
+ }
+
+ if ((i + 1) % batchSyncPartitionNum == 0) {
+ result.add(alterSQL.toString());
+ alterSQL = getAlterTableDropPrefix(tableName);
+ }
+ }
+ // add left partitions to result
+ if (partitions.size() % batchSyncPartitionNum != 0) {
+ result.add(alterSQL.toString());
+ }
+ return result;
+ }
+
+ public StringBuilder getAlterTableDropPrefix(String tableName) {
+ StringBuilder alterSQL = new StringBuilder("ALTER TABLE ");
+ alterSQL.append(HIVE_ESCAPE_CHARACTER).append(config.databaseName)
Review comment:
ahhh, keep as it is :>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
