zhangyue19921010 commented on a change in pull request #4078:
URL: https://github.com/apache/hudi/pull/4078#discussion_r777896842
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieArchivedTimeline.java
##########
@@ -218,7 +219,7 @@ private HoodieInstant readCommit(GenericRecord record,
boolean loadDetails) {
// Sort files by version suffix in reverse (implies reverse
chronological order)
Arrays.sort(fsStatuses, new ArchiveFileVersionComparator());
- List<HoodieInstant> instantsInRange = new ArrayList<>();
+ Set<HoodieInstant> instantsInRange = new HashSet<>();
Review comment:
Maybe we could use HashSet to avoid duplicate instants.
This is based on there are no same instant time in the hoodie time line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
