codope opened a new pull request #4536:
URL: https://github.com/apache/hudi/pull/4536
…not set
## What is the purpose of the pull request
If user has not set a config and `setDefaults()` is not called before
checking the config, then `getBoolean` (or getString, getInt) returns null
which can cause NPE. At least, for boolean configs we should return default
value if it is provided in config declaration. This does not change the
behavior. For string or int configs, we should let it return null because there
can be checks in the code based on null or empty. In that case we don't want to
set some value.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test
coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please
describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
