YannByron commented on a change in pull request #4083:
URL: https://github.com/apache/hudi/pull/4083#discussion_r781051972
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -90,6 +90,11 @@
// It is here so that both the client and deltastreamer use the same
reference
public static final String DELTASTREAMER_CHECKPOINT_KEY =
"deltastreamer.checkpoint.key";
+ public static final ConfigProperty<String> DATABASE_NAME = ConfigProperty
+ .key("hoodie.database.name")
+ .defaultValue("default")
Review comment:
It's not like hive. Users can write by Spark dataframe. That set
`default` as the default value will mislead hudi to do something wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
