codope commented on a change in pull request #4540:
URL: https://github.com/apache/hudi/pull/4540#discussion_r781314302
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieRealtimeInputFormatUtils.java
##########
@@ -94,16 +94,16 @@
HoodieTableMetaClient metaClient =
partitionsToMetaClient.get(partitionPath);
if (!fsCache.containsKey(metaClient)) {
HoodieLocalEngineContext engineContext = new
HoodieLocalEngineContext(conf);
- HoodieTableFileSystemView fsView =
FileSystemViewManager.createInMemoryFileSystemView(engineContext,
- metaClient, HoodieInputFormatUtils.buildMetadataConfig(conf));
+ HoodieTableFileSystemView fsView =
FileSystemViewManager.createInMemoryFileSystemViewWithTimeline(engineContext,
+ metaClient, HoodieInputFormatUtils.buildMetadataConfig(conf),
metaClient.getActiveTimeline());
fsCache.put(metaClient, fsView);
}
HoodieTableFileSystemView fsView = fsCache.get(metaClient);
String relPartitionPath = FSUtils.getRelativePartitionPath(new
Path(metaClient.getBasePath()), partitionPath);
// Both commit and delta-commits are included - pick the latest
completed one
Option<HoodieInstant> latestCompletedInstant =
-
metaClient.getActiveTimeline().getCommitsTimeline().filterCompletedInstants().lastInstant();
+
metaClient.getActiveTimeline().getWriteTimeline().filterCompletedInstants().lastInstant();
Review comment:
The writeTimeline will also contain the compaction instant compared to
commitsTimeline, but how does that matter for this scenario? Since latest
active timeline is already being passed to
`createInMemoryFileSystemViewWithTimeline` then latest file slice would contain
the file group due to commit during ongoing compaction right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
