vinothchandar commented on pull request #4449: URL: https://github.com/apache/hudi/pull/4449#issuecomment-1009537360
cc @prashantwason as well . I still think we need to avoid the references to HoodieMetadataPayload directly from HFileReader and HoodieHFileDataBlock level. The issue here that these layers currently don't take in any config object. For HFileReader - there is a hadoop `configuration` object that can be used to pass the field name For HFileDataBlock - the log format writer creation could take an additional param. Alternatively, a good Hudi citizen contributor (I just made that up), would have to plumb the interfaces more nicely to take a `Properties` and pass the writeConfig/commonConfig all the way to the reader/writer. This will be useful for many things going forward. This has to happen in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
