alexeykudinkin commented on a change in pull request #4417:
URL: https://github.com/apache/hudi/pull/4417#discussion_r782436377
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieHFileInputFormat.java
##########
@@ -137,15 +55,6 @@ protected HoodieDefaultTimeline
filterInstantsTimeline(HoodieDefaultTimeline tim
@Override
protected boolean isSplitable(FileSystem fs, Path filename) {
// This file isn't splittable.
- return false;
- }
-
- public void setConf(Configuration conf) {
- this.conf = conf;
- }
-
- @Override
- public Configuration getConf() {
- return conf;
+ return includeLogFilesForSnapShotView();
Review comment:
Good catch! I think that's actually an IDEA volunteered to do overly
smart method extraction. Will revert
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieParquetInputFormat.java
##########
@@ -250,6 +122,61 @@ protected FileSplit makeSplit(Path file, long start, long
length,
return split;
}
+ private RecordReader<NullWritable, ArrayWritable>
getRecordReaderInternal(InputSplit split,
+
JobConf job,
+
Reporter reporter) throws IOException {
+ return mapredParquetInputFormat.getRecordReader(split, job, reporter);
Review comment:
Empty ctor actually will just channel into the other one:
```
public MapredParquetInputFormat() {
this(new
ParquetInputFormat<ArrayWritable>(DataWritableReadSupport.class));
}
protected MapredParquetInputFormat(final ParquetInputFormat<ArrayWritable>
inputFormat) {
this.realInput = inputFormat;
vectorizedSelf = new VectorizedParquetInputFormat();
}
```
Empty ctor is what this class was using before as well when it was
inheriting from `MapredParquetInputFormat` directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
