leesf commented on a change in pull request #4350:
URL: https://github.com/apache/hudi/pull/4350#discussion_r783024554
##########
File path:
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/hudi/SparkAdapter.scala
##########
@@ -92,4 +95,31 @@ trait SparkAdapter extends Serializable {
* ParserInterface#parseMultipartIdentifier is supported since spark3, for
spark2 this should not be called.
*/
def parseMultipartIdentifier(parser: ParserInterface, sqlText: String):
Seq[String]
+
+ def isHoodieTable(table: LogicalPlan, spark: SparkSession): Boolean = {
Review comment:
> Is there any difference with **hoodieSqlCommonUtils.isHoodieTable**? I
see sometimes we use **adapter.isHoodieTable**, sometimes use
**hoodieSqlCommonUtils.isHoodieTable**
in fact **hoodieSqlCommonUtils.isHoodieTable** method is used in v1 codebase
to judge if a table is a hoodie table in v1 codebase , but
**adapter.isHoodieTable** method is to judge if a table is a hoodie table in v2
codebase, change the name would be better to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
