[GitHub] [hudi] alexeykudinkin commented on a change in pull request #4333: [HUDI-431] Adding support for Parquet in MOR `LogBlock`s

Thu, 13 Jan 2022 18:12:08 -0800 


alexeykudinkin commented on a change in pull request #4333:
URL: https://github.com/apache/hudi/pull/4333#discussion_r784457956



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java
##########
@@ -497,4 +489,32 @@ private void flushToDiskIfRequired(HoodieRecord record) {
       numberOfRecords = 0;
     }
   }
+
+  protected void appendDataAndDeleteBlocks(Map<HeaderMetadataType, String> 
header) {

Review comment:
       Frankly, can't understand why this method got moved. Nothing should have 
changed here. Let me revert this 

##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java
##########
@@ -497,4 +489,32 @@ private void flushToDiskIfRequired(HoodieRecord record) {
       numberOfRecords = 0;
     }
   }
+
+  protected void appendDataAndDeleteBlocks(Map<HeaderMetadataType, String> 
header) {

Review comment:
       Oh, i've found the root-cause of those inexplicable changes -- i guess 
after upgrade of IDEA i've got new box "Rearrange code" ticked automatically 
(never ticked it myself) and i've confirmed it being the root-cause of those 
random re-orderings
   
   <img width="357" alt="Screen Shot 2022-01-13 at 6 10 49 PM" 
src="https://user-images.githubusercontent.com/428277/149439483-0d67b659-a61c-4ffe-807e-70a07e9d7d0e.png";>
    




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to