YannByron commented on a change in pull request #4180:
URL: https://github.com/apache/hudi/pull/4180#discussion_r784483529



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java
##########
@@ -241,6 +246,26 @@ private void deleteInstantFile(HoodieInstant instant) {
     return readDataFromPath(detailPath);
   }
 
+  /**
+   * Get the last instant with valid data, and convert this to 
HoodieCommitMetadata
+   */
+  public Option<Pair<HoodieInstant, HoodieCommitMetadata>> 
getLastCommitMetadataWithValidData() {

Review comment:
       OK, I'll add some UT for this.
   But, a little problem is that due to a real hudi table and operations, maybe 
these can't be put in `hudi-common` sub-project. I'll put in 
`hudi-spark-datasource` project.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to