boneanxs commented on a change in pull request #4350:
URL: https://github.com/apache/hudi/pull/4350#discussion_r784737319
##########
File path:
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/hudi/SparkAdapter.scala
##########
@@ -92,4 +95,31 @@ trait SparkAdapter extends Serializable {
* ParserInterface#parseMultipartIdentifier is supported since spark3, for
spark2 this should not be called.
*/
def parseMultipartIdentifier(parser: ParserInterface, sqlText: String):
Seq[String]
+
+ def isHoodieTable(table: LogicalPlan, spark: SparkSession): Boolean = {
Review comment:
Thanks for your reply, and please correct me if I'm wrong. Can we just
move the method implementation out from SparkAdapter to Spark2Adapter,
Spark2Adapter can judge if a table is a hoodie table in v1 codebase, while
Spark3Adapter can judge it by v2 codebase, by this, I think the method
**hoodieSqlCommonUtils.isHoodieTable** can be simply removed?
Looking forward this PR can be merged as soon as possible, this is an
excellent work as we can support many other features with DSV2 based on this. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
