javeme commented on code in PR #268:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/268#discussion_r861538473
##########
hugegraph-hubble/hubble-dist/assembly/travis/run-api-test.sh:
##########
@@ -2,8 +2,11 @@
set -ev
-"$TRAVIS_DIR"/install-hugegraph-hubble.sh
+EXEC_PATH="hubble-dist/assembly/travis"
Review Comment:
keep "TRAVIS_DIR" style
##########
hugegraph-hubble/hubble-dist/assembly/travis/install-hugegraph-hubble.sh:
##########
@@ -4,9 +4,10 @@ set -ev
TRAVIS_DIR=$(dirname "$0")
-mvn -e clean package -DskipTests
+echo "$TRAVIS_DIR"
+pwd && mvn -e -X clean package -DskipTests
-cp "${TRAVIS_DIR}"/jacocoagent.jar hugegraph-hubble-*/lib
-cp "${TRAVIS_DIR}"/start-hubble.sh hugegraph-hubble-*/bin
+cp "${TRAVIS_DIR}"/jacocoagent.jar hugegraph-hubble-*/lib || exit 1
Review Comment:
add `HUBBLE_DIR=$(echo hugegraph-hubble-*.*)` and use `${HUBBLE_DIR}/lib`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
