javeme commented on code in PR #263:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/263#discussion_r861550439
##########
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/source/jdbc/JDBCSource.java:
##########
@@ -63,20 +63,20 @@ public void check() throws IllegalArgumentException {
E.checkArgument(this.database != null, "The database can't be null");
E.checkArgument(this.username != null, "The username can't be null");
E.checkArgument(this.password != null, "The password can't be null");
- E.checkArgument(this.table != null || this.sql != null, "At least one
of table and sql can't be null");
+ E.checkArgument(this.table != null || this.customSQL != null, "At
least one of table and sql can't be null");
Review Comment:
wrap line after "," to keep 80 chars each line.
##########
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/reader/jdbc/RowFetcher.java:
##########
@@ -131,15 +131,15 @@ public List<Line> nextBatch() throws SQLException {
}
String select = this.source.existsSql() ?
- this.source.sql() :
this.source.vendor().buildSelectSql(this.source, this.nextStartRow);
+ this.source.customSQL() :
this.source.vendor().buildSelectSql(this.source, this.nextStartRow);
Review Comment:
can we adjust code style:
https://github.com/apache/incubator-hugegraph-doc/wiki/HugeGraph%E4%BB%A3%E7%A0%81%E9%A3%8E%E6%A0%BC%E6%8C%87%E5%8D%97
##########
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/source/jdbc/JDBCSource.java:
##########
@@ -63,20 +63,20 @@ public void check() throws IllegalArgumentException {
E.checkArgument(this.database != null, "The database can't be null");
E.checkArgument(this.username != null, "The username can't be null");
E.checkArgument(this.password != null, "The password can't be null");
- E.checkArgument(this.table != null || this.sql != null, "At least one
of table and sql can't be null");
+ E.checkArgument(this.table != null || this.customSQL != null, "At
least one of table and sql can't be null");
this.schema = this.vendor.checkSchema(this);
if (this.driver == null) {
this.driver = this.vendor.defaultDriver();
}
}
- public String sql() {
- return this.sql;
+ public String customSQL() {
+ return this.customSQL;
}
public boolean existsSql() {
- return this.sql != null;
+ return this.customSQL != null;
Review Comment:
could you please also update existsSql() name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
