[GitHub] [incubator-hugegraph] seagle-yuan commented on a diff in pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java

Tue, 10 May 2022 06:46:21 -0700 


seagle-yuan commented on code in PR #1842:
URL: 
https://github.com/apache/incubator-hugegraph/pull/1842#discussion_r869246440


##########
hugegraph-test/src/main/java/com/baidu/hugegraph/unit/core/RolePermissionTest.java:
##########
@@ -79,59 +85,98 @@ public void testBuiltinNone() {
         Assert.assertSame(none, RolePermission.builtin(none));
         Assert.assertSame(none, RolePermission.builtin(role1));
 
-        
Assert.assertEquals("{\"roles\":{\"none\":{\"NONE\":[{\"type\":\"ALL\",\"label\":\"*\",\"properties\":null}]}}}",
 none.toJson());
-        RolePermission role = 
RolePermission.fromJson("{\"roles\":{\"none\":{\"NONE\":[{\"type\":\"ALL\",\"label\":\"write\",\"properties\":null}]}}");
+        Assert.assertEquals("{\"roles\":{\"none\":{\"NONE\":[" +
+                                    
"{\"type\":\"ALL\",\"label\":\"*\",\"properties\":null}]}}}"
+                                    , none.toJson());
+        RolePermission role = 
RolePermission.fromJson("{\"roles\":{\"none\":{\"NONE\":[" +

Review Comment:
   can you put the comma on line 90 on the previous line, and align with left 
parenthesis
   
![7](https://user-images.githubusercontent.com/13429553/167641371-55814f48-4f77-49af-9e9b-130b0f83aab8.JPG)
   
   



##########
hugegraph-test/src/main/java/com/baidu/hugegraph/unit/cassandra/CassandraTest.java:
##########
@@ -42,7 +41,7 @@ public class CassandraTest {
     @Before
     public void setup() {
         OptionSpace.register("cassandra",
-        "com.baidu.hugegraph.backend.store.cassandra.CassandraOptions");
+            "com.baidu.hugegraph.backend.store.cassandra.CassandraOptions");
     }
 
     @After

Review Comment:
   can you align such as 
   
![5](https://user-images.githubusercontent.com/13429553/167639578-e92574a0-450f-4460-bb10-f10465bcd8da.jpg)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to