javeme commented on code in PR #331:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/331#discussion_r958624550
##########
hugegraph-tools/src/main/java/com/baidu/hugegraph/cmd/SubCommands.java:
##########
@@ -1058,17 +1060,17 @@ public List<HugeType> convert(String value) {
hugeTypes.add(HugeType.valueOf(type.toUpperCase()));
} catch (IllegalArgumentException e) {
throw new ParameterException(String.format(
- "Invalid --type '%s', valid value is 'all' or " +
- "combination of 'vertex,edge,vertex_label," +
- "edge_label,property_key,index_label'", type));
+ "Invalid --type '%s', valid value is 'all' or " +
Review Comment:
can we keep the origin style? prefer to keep consistent with server
code--change the code style specification: cancel the strict restriction on
indentation
##########
hugegraph-tools/src/main/java/com/baidu/hugegraph/cmd/SubCommands.java:
##########
@@ -1058,17 +1060,17 @@ public List<HugeType> convert(String value) {
hugeTypes.add(HugeType.valueOf(type.toUpperCase()));
} catch (IllegalArgumentException e) {
throw new ParameterException(String.format(
- "Invalid --type '%s', valid value is 'all' or " +
- "combination of 'vertex,edge,vertex_label," +
- "edge_label,property_key,index_label'", type));
+ "Invalid --type '%s', valid value is 'all' or " +
+ "combination of 'vertex,edge,vertex_label," +
+ "edge_label,property_key,index_label'", type));
}
}
return hugeTypes;
}
}
public static class AuthHugeTypeConverter
- implements IStringConverter<List<HugeType>> {
+ implements IStringConverter<List<HugeType>> {
Review Comment:
can we keep the origin style?
##########
hugegraph-tools/src/main/java/com/baidu/hugegraph/formatter/kgdumper/DumpKGFormatter.java:
##########
@@ -101,6 +101,7 @@ private String dumpEntity(JsonVertex vertex)
region.add(((String) edge.getTarget()).split(":", 2)[1]);
regionWeight.add(props.get("weight").toString());
break;
+ default:
Review Comment:
also add break
##########
hugegraph-tools/src/main/java/com/baidu/hugegraph/formatter/kgdumper/SignFS64.java:
##########
@@ -115,7 +137,7 @@ private static String longBytes2String(ByteBuffer buffer) {
}
public static String createSignFs64(String text, String encode)
- throws UnsupportedEncodingException {
+ throws UnsupportedEncodingException {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
