javeme commented on code in PR #325:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/325#discussion_r985083501
##########
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/reader/line/Line.java:
##########
@@ -37,7 +38,9 @@ public Line(String rawLine, String[] names, Object[] values) {
E.checkArgumentNotNull(names, "The names can't be null");
E.checkArgumentNotNull(values, "The values can't be null");
E.checkArgument(names.length == values.length,
- "The length of names %s should be same as values %s");
+ "The length of names %s should be same as values %s",
+ Arrays.toString(names),
Review Comment:
prefer to add if-statement check to avoid unnecessary toString() call:
```java
if (names.length != values.length) {
E.checkArgument(...);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
