javeme commented on code in PR #108:
URL:
https://github.com/apache/incubator-hugegraph-commons/pull/108#discussion_r996234220
##########
pom.xml:
##########
@@ -164,6 +180,43 @@
</execution>
</executions>
</plugin>
+ <!-- Apache RAT for license check -->
+ <plugin>
+ <groupId>org.apache.rat</groupId>
+ <artifactId>apache-rat-plugin</artifactId>
Review Comment:
does it enable auto check in CI?
##########
hugegraph-common/src/test/java/org/apache/hugegraph/unit/concurrent/BarrierEventTest.java:
##########
@@ -13,7 +32,7 @@
public class BarrierEventTest {
- private static int WAIT_THREADS_COUNT = 10;
+ private static final int WAIT_THREADS_COUNT = 10;
Review Comment:
Separate from this PR? since this pr can be used as a guide for other repos.
##########
hugegraph-common/pom.xml:
##########
@@ -11,7 +27,7 @@
</parent>
<artifactId>hugegraph-common</artifactId>
- <name>${artifactId}</name>
+ <name>${project.artifactId}</name>
Review Comment:
Separate from this PR? since this pr can be used as a guide for other repos.
##########
pom.xml:
##########
@@ -18,9 +34,9 @@
</description>
<parent>
- <groupId>org.sonatype.oss</groupId>
- <artifactId>oss-parent</artifactId>
- <version>7</version>
+ <groupId>org.apache</groupId>
Review Comment:
Separate from this PR? since this pr can be used as a guide for other repos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
