imbajin commented on code in PR #338:
URL: 
https://github.com/apache/incubator-hugegraph-toolchain/pull/338#discussion_r1000104681


##########
pom.xml:
##########
@@ -361,6 +375,47 @@
                     </execution>
                 </executions>
             </plugin>
+
+            <!-- Apache RAT for license check -->
+            <plugin>
+                <groupId>org.apache.rat</groupId>
+                <artifactId>apache-rat-plugin</artifactId>
+                <version>0.15</version>
+                <configuration>
+                    <excludes>
+                        <exclude>**/*.versionsBackup</exclude>
+                        <exclude>**/*.log</exclude>
+                        <exclude>**/*.txt</exclude>
+                        <exclude>**/*.csv</exclude>
+                        <exclude>**/*.json</exclude>
+                        <exclude>**/*.conf</exclude>
+                        <exclude>**/*.properties</exclude>
+                        <exclude>**/*.gitattributes</exclude>
+                        <exclude>dist/**/*</exclude>
+                        <exclude>docs/**/*</exclude>
+                        <exclude>scripts/dev/reviewers</exclude>
+                        <exclude>**/*.md</exclude>
+                        <exclude>**/dependency-reduced-pom.xml</exclude>
+                        <exclude>**/logs/*.log</exclude>
+                        <exclude>**/target/*</exclude>
+                        <exclude>style/*</exclude>
+                        <exclude>ChangeLog</exclude>
+                        <exclude>CONFIG.ini</exclude>
+                        <exclude>GROUPS</exclude>
+                        <exclude>OWNERS</exclude>
+                        <!-- GitHub -->
+                        <exclude>.github/**/*</exclude>

Review Comment:
   OK, files that will be not **packaged** into source/binary should be 
excluded.
   
   such as like `.idea` / `.github` / `.traivis` / `.git`, I'll update it later 
(add add it into CI step)
   
   BTW, any suggestion for running rat better in CI? (now it can't alert error, 
just generates reports..)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to