javeme commented on code in PR #1989:
URL:
https://github.com/apache/incubator-hugegraph/pull/1989#discussion_r1004676308
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/StandardHugeGraph.java:
##########
@@ -184,8 +184,8 @@ public StandardHugeGraph(HugeConfig config) {
this.readRateLimiter = readLimit > 0 ?
RateLimiter.create(readLimit) : null;
- boolean ramtableEnable = config.get(CoreOptions.QUERY_RAMTABLE_ENABLE);
- if (ramtableEnable) {
+ boolean ramTableEnable = config.get(CoreOptions.QUERY_RAMTABLE_ENABLE);
Review Comment:
prefer to keep the old name since we treat ramtable as a term
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/analyzer/AnalyzerFactory.java:
##########
@@ -27,7 +27,7 @@
public class AnalyzerFactory {
- private static Map<String, Class<? extends Analyzer>> analyzers;
+ private static final Map<String, Class<? extends Analyzer>> analyzers;
Review Comment:
can you split changes (like the code improve) into a separate pr?
##########
hugegraph-core/pom.xml:
##########
@@ -13,6 +13,22 @@
<properties>
<top.level.dir>${basedir}/..</top.level.dir>
+ <jraft.version>1.3.11</jraft.version>
+ <ohc.version>0.7.4</ohc.version>
+ <lz4.version>1.8.0</lz4.version>
+ <apdplat-word.version>1.3.1</apdplat-word.version>
+
<lucene-analyzers-smartcn.version>8.11.2</lucene-analyzers-smartcn.version>
+ <mmseg4j-core.version>1.10.0</mmseg4j-core.version>
+ <jcseg.version>2.6.2</jcseg.version>
+ <hanlp.version>portable-1.8.3</hanlp.version>
+ <ansj-seg.version>5.1.6</ansj-seg.version>
+ <lucene-core.version>8.11.2</lucene-core.version>
+ <jieba-analysis.version>1.0.2</jieba-analysis.version>
+ <ikanalyzer.version>2012_u6</ikanalyzer.version>
+ <commons-compress.version>1.21</commons-compress.version>
+ <eclipse-collections.version>11.1.0</eclipse-collections.version>
+ <fastutil.version>8.5.9</fastutil.version>
+ <jjwt.version>0.11.5</jjwt.version>
Review Comment:
can you highlight which versions are changed? or it's ok to just leave some
comments in the reply
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
