javeme commented on code in PR #339: URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/339#discussion_r1008246247
########## hugegraph-loader/assembly/travis/install-hugegraph-from-tar.sh: ########## @@ -3,18 +3,19 @@ set -ev if [[ $# -ne 1 ]]; then - echo "Must pass server version of hugegraph" - exit 1 + echo "Must input exist git commit id of hugegraph server" && exit 1 fi VERSION=$1 HUGEGRAPH_LINK="https://github.com/hugegraph/hugegraph/releases/download/v${VERSION}/hugegraph-${VERSION}.tar.gz"; wget "${HUGEGRAPH_LINK}" || exit 1 -tar -zxvf hugegraph-${VERSION}.tar.gz +# TODO: lack incubator after apache package release (update it later) +tar zxvf hugegraph-${VERSION}.tar.gz Review Comment: we can define an env var for it like PACKAGE_PREFIX="incubator-hugegraph" ########## hugegraph-loader/assembly/travis/install-hugegraph-from-tar.sh: ########## @@ -3,18 +3,19 @@ set -ev if [[ $# -ne 1 ]]; then - echo "Must pass server version of hugegraph" - exit 1 + echo "Must input exist git commit id of hugegraph server" && exit 1 Review Comment: Must input an existing commit id of hugegraph server ########## hugegraph-loader/assembly/travis/install-hugegraph-from-source.sh: ########## @@ -3,24 +3,25 @@ set -ev if [[ $# -ne 1 ]]; then - echo "Must pass commit id of hugegraph repo" - exit 1 + echo "Must input exist git commit id of hugegraph server" && exit 1 fi COMMIT_ID=$1 -HUGEGRAPH_GIT_URL="https://github.com/hugegraph/hugegraph.git"; +HUGEGRAPH_GIT_URL="https://github.com/apache/hugegraph.git"; git clone --depth 100 ${HUGEGRAPH_GIT_URL} hugegraph cd hugegraph git checkout "${COMMIT_ID}" -mvn package -DskipTests +mvn package -DskipTests -Dmaven.javadoc.skip=true | grep -v "Downloading\|Downloaded\|Progress" +# TODO: lack incubator after apache package release (update it later) mv hugegraph-*.tar.gz ../ cd ../ rm -rf hugegraph -tar -zxvf hugegraph-*.tar.gz +tar zxvf hugegraph-*.tar.gz Review Comment: update "hugegraph-*" like the script in hugegraph server -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
