[incubator-hugegraph-toolchain] branch master updated: Fix flaky tests in IndexLabelTest (#398)

[jermy]

This is an automated email from the ASF dual-hosted git repository.

jermy pushed a commit to branch master
in repository 
https://gitbox.apache.org/repos/asf/incubator-hugegraph-toolchain.git


The following commit(s) were added to refs/heads/master by this push:
     new e02b7d1b Fix flaky tests in IndexLabelTest (#398)
e02b7d1b is described below

commit e02b7d1b05f913430df9ea2a951e240f5566eb59
Author: Aditya Kumbhar <31104730+aditya-kumb...@users.noreply.github.com>
AuthorDate: Tue Dec 13 09:30:16 2022 -0600

    Fix flaky tests in IndexLabelTest (#398)
    
    Fix flaky tests in IndexLabelTest due to non deterministic JSON key ordering
---
 .../java/org/apache/hugegraph/unit/IndexLabelTest.java  | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git 
a/hugegraph-client/src/test/java/org/apache/hugegraph/unit/IndexLabelTest.java 
b/hugegraph-client/src/test/java/org/apache/hugegraph/unit/IndexLabelTest.java
index 55e62e58..a01a2f8e 100644
--- 
a/hugegraph-client/src/test/java/org/apache/hugegraph/unit/IndexLabelTest.java
+++ 
b/hugegraph-client/src/test/java/org/apache/hugegraph/unit/IndexLabelTest.java
@@ -19,6 +19,8 @@
 
 package org.apache.hugegraph.unit;
 
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
 import org.junit.Test;
 
 import org.apache.hugegraph.exception.NotSupportException;
@@ -30,7 +32,7 @@ import org.apache.hugegraph.util.JsonUtil;
 public class IndexLabelTest {
 
     @Test
-    public void testIndexLabel() {
+    public void testIndexLabel() throws JsonProcessingException {
         IndexLabel.Builder builder = new IndexLabel.BuilderImpl("personByAge",
                                                                 null);
         IndexLabel indexLabel = builder.onV("person")
@@ -44,12 +46,13 @@ public class IndexLabelTest {
                       "\"base_value\":\"person\"," +
                       "\"index_type\":\"SECONDARY\",\"fields\":[\"age\"]," +
                       "\"rebuild\":true}";
-        Assert.assertEquals(json, JsonUtil.toJson(indexLabel));
+        ObjectMapper mapper = new ObjectMapper();
+        Assert.assertEquals(mapper.readTree(json), 
mapper.readTree(JsonUtil.toJson(indexLabel)));
         Assert.assertEquals(HugeType.INDEX_LABEL.string(), indexLabel.type());
     }
 
     @Test
-    public void testIndexLabelV49() {
+    public void testIndexLabelV49() throws JsonProcessingException {
         IndexLabel.Builder builder = new IndexLabel.BuilderImpl("personByAge",
                                                                 null);
         IndexLabel indexLabel = builder.onV("person")
@@ -63,7 +66,8 @@ public class IndexLabelTest {
                       "\"check_exist\":true,\"base_type\":\"VERTEX_LABEL\"," +
                       "\"base_value\":\"person\"," +
                       "\"index_type\":\"SECONDARY\",\"fields\":[\"age\"]}";
-        Assert.assertEquals(json, JsonUtil.toJson(indexLabelV49));
+        ObjectMapper mapper = new ObjectMapper();
+        Assert.assertEquals(mapper.readTree(json), 
mapper.readTree(JsonUtil.toJson(indexLabelV49)));
         Assert.assertEquals(HugeType.INDEX_LABEL.string(),
                             indexLabelV49.type());
 
@@ -71,7 +75,7 @@ public class IndexLabelTest {
     }
 
     @Test
-    public void testIndexLabelV56() {
+    public void testIndexLabelV56() throws JsonProcessingException {
         IndexLabel.Builder builder = new IndexLabel.BuilderImpl("personByAge",
                                                                 null);
         IndexLabel indexLabel = builder.onV("person")
@@ -85,7 +89,8 @@ public class IndexLabelTest {
                       "\"check_exist\":true,\"user_data\":{}," +
                       
"\"base_type\":\"VERTEX_LABEL\",\"base_value\":\"person\"," +
                       "\"index_type\":\"SECONDARY\",\"fields\":[\"age\"]}";
-        Assert.assertEquals(json, JsonUtil.toJson(indexLabelV56));
+        ObjectMapper mapper = new ObjectMapper();
+        Assert.assertEquals(mapper.readTree(json), 
mapper.readTree(JsonUtil.toJson(indexLabelV56)));
         Assert.assertEquals(HugeType.INDEX_LABEL.string(),
                             indexLabelV56.type());