imbajin commented on PR #452:
URL: https://github.com/apache/hugegraph-doc/pull/452#issuecomment-3958279743

   > > @bitflicker64 Hi, still found some 404 links & broken image link:
   > > 
   > > * 
[hugegraph.apache.org/docs/introduction/README](https://hugegraph.apache.org/docs/introduction/README)
 (both in EN & CN)
   > > * 
[hugegraph.apache.org/docs/quickstart/hugegraph-ai/quick_start](https://hugegraph.apache.org/docs/quickstart/hugegraph-ai/quick_start/)
   > 
   > Makes sense those are absolute 
[hugegraph.apache.org](https://hugegraph.apache.org/)... links, and the 
validator currently skips all http/https targets, so it won’t catch site 404s. 
We can either update the docs to use /docs/... (so they’re checked), or add an 
optional allowlist-based external check for hugegraph.apache.org. Would you 
prefer I add an optional allowlist , or keep CI limited to internal links and 
handle these in follow up fixes?
   
   BTW, already fixed the first issue in 
https://github.com/apache/hugegraph-doc/pull/454/changes/b1fccc8faf7e424e1e16d059295d67e84ec726f1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to