imbajin commented on code in PR #2966:
URL: https://github.com/apache/hugegraph/pull/2966#discussion_r2911693010
##########
hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/api/ManagerApiTest.java:
##########
@@ -981,4 +981,45 @@ public void testUserWithDifferentRolesInMultipleSpaces() {
Assert.assertTrue("Only graphb1 should remain in spaceb",
graphsList.contains("graphb1") &&
!graphsList.contains("graphb2"));
}
+
+ @Test
+ public void testStandaloneModeForbidsAllEndpoints() {
+ Assume.assumeFalse("skip this test for hstore (PD mode)",
Review Comment:
⚠️ This standalone test never actually runs. `ManagerApiTest#setUpClass()`
has a class-level `Assume.assumeTrue(... hstore ...)`, so JUnit skips the whole
class before the method-level `assumeFalse()` is reached here. That means this
PR adds no regression coverage for the new standalone behavior. Please move
these assertions into a test class that is allowed to run without PD, or relax
the class-level guard so this method can execute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
