This is an automated email from the ASF dual-hosted git repository.
imbajin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hugegraph-ai.git
The following commit(s) were added to refs/heads/main by this push:
new e14c25d2 fix(api): fix POST /config/graph AttributeError (req.name ->
req.graph) (#337)
e14c25d2 is described below
commit e14c25d22f1d6a802908f37fd4b7ec615398be63
Author: mengmeng.lin <[email protected]>
AuthorDate: Tue May 19 12:54:28 2026 +0800
fix(api): fix POST /config/graph AttributeError (req.name -> req.graph)
(#337)
## Summary
- Fix `req.name` to `req.graph` in `rag_api.py:158` to match the
`GraphConfigRequest` model field name
Fixes #330
## Test plan
- [x] `ruff format --check .` and `ruff check .` pass
- [ ] Verify `POST /config/graph` returns success instead of 500
---------
Co-authored-by: linmm <[email protected]>
Co-authored-by: Claude Opus 4.6 <[email protected]>
Co-authored-by: imbajin <[email protected]>
---
hugegraph-llm/src/hugegraph_llm/api/rag_api.py | 2 +-
hugegraph-llm/src/tests/api/test_rag_api.py | 62 ++++++++++++++++++++++++++
2 files changed, 63 insertions(+), 1 deletion(-)
diff --git a/hugegraph-llm/src/hugegraph_llm/api/rag_api.py
b/hugegraph-llm/src/hugegraph_llm/api/rag_api.py
index 3838df2f..76217251 100644
--- a/hugegraph-llm/src/hugegraph_llm/api/rag_api.py
+++ b/hugegraph-llm/src/hugegraph_llm/api/rag_api.py
@@ -155,7 +155,7 @@ def rag_http_api(
@router.post("/config/graph", status_code=status.HTTP_201_CREATED)
def graph_config_api(req: GraphConfigRequest):
# Accept status code
- res = apply_graph_conf(req.url, req.name, req.user, req.pwd, req.gs,
origin_call="http")
+ res = apply_graph_conf(req.url, req.graph, req.user, req.pwd, req.gs,
origin_call="http")
return generate_response(RAGResponse(status_code=res, message="Missing
Value"))
# TODO: restructure the implement of llm to three types, like
"/config/chat_llm"
diff --git a/hugegraph-llm/src/tests/api/test_rag_api.py
b/hugegraph-llm/src/tests/api/test_rag_api.py
new file mode 100644
index 00000000..55fbd679
--- /dev/null
+++ b/hugegraph-llm/src/tests/api/test_rag_api.py
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from unittest.mock import Mock
+
+from fastapi import APIRouter, FastAPI, status
+from fastapi.testclient import TestClient
+
+from hugegraph_llm.api.rag_api import rag_http_api
+
+
+def test_graph_config_api_passes_graph_field_to_apply_graph_conf():
+ apply_graph_conf = Mock(return_value=status.HTTP_200_OK)
+ router = APIRouter()
+ rag_http_api(
+ router,
+ rag_answer_func=Mock(),
+ graph_rag_recall_func=Mock(),
+ apply_graph_conf=apply_graph_conf,
+ apply_llm_conf=Mock(),
+ apply_embedding_conf=Mock(),
+ apply_reranker_conf=Mock(),
+ gremlin_generate_selective_func=Mock(),
+ )
+ app = FastAPI()
+ app.include_router(router)
+
+ response = TestClient(app).post(
+ "/config/graph",
+ json={
+ "url": "127.0.0.1:8080",
+ "graph": "custom_graph",
+ "user": "admin",
+ "pwd": "secret",
+ "gs": "space_a",
+ },
+ )
+
+ assert response.status_code == status.HTTP_201_CREATED
+ assert response.json() == {"message": "Connection successful. Configured
finished."}
+ apply_graph_conf.assert_called_once_with(
+ "127.0.0.1:8080",
+ "custom_graph",
+ "admin",
+ "secret",
+ "space_a",
+ origin_call="http",
+ )
