[iceberg] branch master updated: Core: Use .as() with AssertJ (#2706)

[blue]

This is an automated email from the ASF dual-hosted git repository.

blue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new b2ebf22  Core: Use .as() with AssertJ (#2706)
b2ebf22 is described below

commit b2ebf2271a27cac8b5296b9d6f80acb013f8529f
Author: Eduard Tudenhöfner <etudenhoef...@gmail.com>
AuthorDate: Thu Jun 17 20:24:43 2021 +0200

    Core: Use .as() with AssertJ (#2706)
    
    `.withFailMessage(..)` was mistakenly used and was therefore overriding
    the actual error reporting, making debugging difficult.
---
 api/src/test/java/org/apache/iceberg/AssertHelpers.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/api/src/test/java/org/apache/iceberg/AssertHelpers.java 
b/api/src/test/java/org/apache/iceberg/AssertHelpers.java
index 3f8c7fc..e4eded3 100644
--- a/api/src/test/java/org/apache/iceberg/AssertHelpers.java
+++ b/api/src/test/java/org/apache/iceberg/AssertHelpers.java
@@ -41,7 +41,7 @@ public class AssertHelpers {
                                   String containedInMessage,
                                   Callable callable) {
     AbstractThrowableAssert<?, ? extends Throwable> check = 
Assertions.assertThatThrownBy(callable::call)
-        .withFailMessage(message)
+        .as(message)
         .isInstanceOf(expected);
     if (null != containedInMessage) {
       check.hasMessageContaining(containedInMessage);
@@ -61,7 +61,7 @@ public class AssertHelpers {
                                   String containedInMessage,
                                   Runnable runnable) {
     AbstractThrowableAssert<?, ? extends Throwable> check = 
Assertions.assertThatThrownBy(runnable::run)
-        .withFailMessage(message)
+        .as(message)
         .isInstanceOf(expected);
     if (null != containedInMessage) {
       check.hasMessageContaining(containedInMessage);
@@ -105,7 +105,7 @@ public class AssertHelpers {
                                        String containedInMessage,
                                        Runnable runnable) {
     Assertions.assertThatThrownBy(runnable::run)
-        .withFailMessage(message)
+        .as(message)
         .getCause()
         .isInstanceOf(expected)
         .hasMessageContaining(containedInMessage);