This is an automated email from the ASF dual-hosted git repository.

blue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new bf2f33acbd Puffin: Inline PuffinWriter.writeFully (#5088)
bf2f33acbd is described below

commit bf2f33acbda2f8b41342c5e4e32a285dba56cb9b
Author: Piotr Findeisen <[email protected]>
AuthorDate: Mon Jun 20 16:59:36 2022 +0200

    Puffin: Inline PuffinWriter.writeFully (#5088)
---
 core/src/main/java/org/apache/iceberg/puffin/PuffinWriter.java | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/core/src/main/java/org/apache/iceberg/puffin/PuffinWriter.java 
b/core/src/main/java/org/apache/iceberg/puffin/PuffinWriter.java
index 1257c778f4..6b4a1e9dd3 100644
--- a/core/src/main/java/org/apache/iceberg/puffin/PuffinWriter.java
+++ b/core/src/main/java/org/apache/iceberg/puffin/PuffinWriter.java
@@ -78,7 +78,7 @@ public class PuffinWriter implements FileAppender<Blob> {
       PuffinCompressionCodec codec = 
MoreObjects.firstNonNull(blob.requestedCompression(), defaultBlobCompression);
       ByteBuffer rawData = PuffinFormat.compress(codec, blob.blobData());
       int length = rawData.remaining();
-      writeFully(rawData);
+      IOUtil.writeFully(outputStream, rawData);
       writtenBlobsMetadata.add(new BlobMetadata(blob.type(), 
blob.inputFields(), fileOffset, length,
           codec.codecName(), blob.properties()));
     } catch (IOException e) {
@@ -132,7 +132,7 @@ public class PuffinWriter implements FileAppender<Blob> {
     ByteBuffer footerPayload = PuffinFormat.compress(footerCompression, 
footerJson);
     outputStream.write(MAGIC);
     int footerPayloadLength = footerPayload.remaining();
-    writeFully(footerPayload);
+    IOUtil.writeFully(outputStream, footerPayload);
     PuffinFormat.writeIntegerLittleEndian(outputStream, footerPayloadLength);
     writeFlags();
     outputStream.write(MAGIC);
@@ -150,10 +150,6 @@ public class PuffinWriter implements FileAppender<Blob> {
     }
   }
 
-  private void writeFully(ByteBuffer buffer) throws IOException {
-    IOUtil.writeFully(outputStream, buffer);
-  }
-
   public long footerSize() {
     return footerSize.orElseThrow(() -> new IllegalStateException("Footer not 
written yet"));
   }

Reply via email to