This is an automated email from the ASF dual-hosted git repository.

blue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new d3953cf000 Core, AWS: Remove throw in finally block (#5222)
d3953cf000 is described below

commit d3953cf000287fde5fa0d0831a5d2496e62f3d74
Author: Eduard Tudenhöfner <[email protected]>
AuthorDate: Tue Jul 12 22:16:33 2022 +0200

    Core, AWS: Remove throw in finally block (#5222)
---
 .../java/org/apache/iceberg/aws/dynamodb/DynamoDbTableOperations.java  | 3 +--
 aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java | 3 +--
 .../src/main/java/org/apache/iceberg/hive/HiveTableOperations.java     | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git 
a/aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbTableOperations.java
 
b/aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbTableOperations.java
index 81157e91b3..3705f92bd5 100644
--- 
a/aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbTableOperations.java
+++ 
b/aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbTableOperations.java
@@ -135,8 +135,7 @@ class DynamoDbTableOperations extends 
BaseMetastoreTableOperations {
           io().deleteFile(newMetadataLocation);
         }
       } catch (RuntimeException e) {
-        LOG.error("Fail to cleanup metadata file at {}", newMetadataLocation, 
e);
-        throw e;
+        LOG.error("Failed to cleanup metadata file at {}", 
newMetadataLocation, e);
       }
     }
   }
diff --git 
a/aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java 
b/aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java
index c223069d75..9415f4e797 100644
--- a/aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java
+++ b/aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java
@@ -247,8 +247,7 @@ class GlueTableOperations extends 
BaseMetastoreTableOperations {
         io().deleteFile(metadataLocation);
       }
     } catch (RuntimeException e) {
-      LOG.error("Fail to cleanup metadata file at {}", metadataLocation, e);
-      throw e;
+      LOG.error("Failed to cleanup metadata file at {}", metadataLocation, e);
     } finally {
       if (lockManager != null) {
         lockManager.release(commitLockEntityId, metadataLocation);
diff --git 
a/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java 
b/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
index 3cdc58064a..42e2e11c87 100644
--- 
a/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
+++ 
b/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
@@ -579,8 +579,7 @@ public class HiveTableOperations extends 
BaseMetastoreTableOperations {
         io().deleteFile(metadataLocation);
       }
     } catch (RuntimeException e) {
-      LOG.error("Fail to cleanup metadata file at {}", metadataLocation, e);
-      throw e;
+      LOG.error("Failed to cleanup metadata file at {}", metadataLocation, e);
     } finally {
       unlock(lockId);
       tableLevelMutex.unlock();

Reply via email to