This is an automated email from the ASF dual-hosted git repository.

etudenhoefner pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new 4263135256 Parquet: Revert workaround for resource usage with zstd 
(#7834)
4263135256 is described below

commit 426313525676387a44aca0c767d2f4f55cd73455
Author: Bryan Keller <[email protected]>
AuthorDate: Tue Jun 13 23:10:04 2023 -0700

    Parquet: Revert workaround for resource usage with zstd (#7834)
---
 parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java       | 4 ----
 .../main/java/org/apache/iceberg/parquet/ParquetCodecFactory.java   | 6 +++++-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java 
b/parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
index 078c4c4b16..d240c84b9e 100644
--- a/parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
+++ b/parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
@@ -1101,12 +1101,8 @@ public class Parquet {
             conf.unset(property);
           }
           optionsBuilder = HadoopReadOptions.builder(conf);
-          // page size not used by decompressors
-          optionsBuilder.withCodecFactory(new ParquetCodecFactory(conf, 0));
         } else {
           optionsBuilder = ParquetReadOptions.builder();
-          // page size not used by decompressors
-          optionsBuilder.withCodecFactory(new ParquetCodecFactory(new 
Configuration(), 0));
         }
 
         for (Map.Entry<String, String> entry : properties.entrySet()) {
diff --git 
a/parquet/src/main/java/org/apache/iceberg/parquet/ParquetCodecFactory.java 
b/parquet/src/main/java/org/apache/iceberg/parquet/ParquetCodecFactory.java
index b61a31f04c..47b9d158c5 100644
--- a/parquet/src/main/java/org/apache/iceberg/parquet/ParquetCodecFactory.java
+++ b/parquet/src/main/java/org/apache/iceberg/parquet/ParquetCodecFactory.java
@@ -32,8 +32,12 @@ import 
org.apache.parquet.hadoop.metadata.CompressionCodecName;
 
 /**
  * This class implements a codec factory that is used when reading from 
Parquet. It adds a
- * workaround for memory issues encountered when reading from zstd-compressed 
files.
+ * workaround for memory issues encountered when reading from zstd-compressed 
files. This is no
+ * longer used, as Parquet 1.13 includes this fix.
+ *
+ * @deprecated will be removed in 1.5.0
  */
+@Deprecated
 public class ParquetCodecFactory extends CodecFactory {
 
   public ParquetCodecFactory(Configuration configuration, int pageSize) {

Reply via email to