This is an automated email from the ASF dual-hosted git repository.
amoghj pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg.git
The following commit(s) were added to refs/heads/main by this push:
new 367dc8b1b9 Core: Add comment property to ViewProperties (#9181)
367dc8b1b9 is described below
commit 367dc8b1b94fd8cbae2b5e4da5d01225e717c49b
Author: Amogh Jahagirdar <[email protected]>
AuthorDate: Tue Dec 5 17:27:42 2023 -0800
Core: Add comment property to ViewProperties (#9181)
---
core/src/main/java/org/apache/iceberg/view/ViewProperties.java | 1 +
.../test/java/org/apache/iceberg/view/TestViewMetadataParser.java | 7 +++++--
.../test/resources/org/apache/iceberg/view/ValidViewMetadata.json | 2 +-
3 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/core/src/main/java/org/apache/iceberg/view/ViewProperties.java
b/core/src/main/java/org/apache/iceberg/view/ViewProperties.java
index b356db7ce0..12b63659bc 100644
--- a/core/src/main/java/org/apache/iceberg/view/ViewProperties.java
+++ b/core/src/main/java/org/apache/iceberg/view/ViewProperties.java
@@ -25,6 +25,7 @@ public class ViewProperties {
public static final String METADATA_COMPRESSION =
"write.metadata.compression-codec";
public static final String METADATA_COMPRESSION_DEFAULT = "gzip";
+ public static final String COMMENT = "comment";
private ViewProperties() {}
}
diff --git
a/core/src/test/java/org/apache/iceberg/view/TestViewMetadataParser.java
b/core/src/test/java/org/apache/iceberg/view/TestViewMetadataParser.java
index 613b8a7fdd..d237236372 100644
--- a/core/src/test/java/org/apache/iceberg/view/TestViewMetadataParser.java
+++ b/core/src/test/java/org/apache/iceberg/view/TestViewMetadataParser.java
@@ -107,7 +107,8 @@ public class TestViewMetadataParser {
.addVersion(version1)
.addVersion(version2)
.setLocation("s3://bucket/test/location")
- .setProperties(ImmutableMap.of("some-key", "some-value"))
+ .setProperties(
+ ImmutableMap.of("some-key", "some-value",
ViewProperties.COMMENT, "some-comment"))
.setCurrentVersionId(2)
.upgradeFormatVersion(1)
.build();
@@ -218,7 +219,9 @@ public class TestViewMetadataParser {
.addVersion(version1)
.addVersion(version2)
.setLocation("s3://bucket/test/location")
- .setProperties(ImmutableMap.of("some-key", "some-value"))
+ .setProperties(
+ ImmutableMap.of(
+ "some-key", "some-value", ViewProperties.COMMENT,
"some-comment"))
.setCurrentVersionId(2)
.upgradeFormatVersion(1)
.build())
diff --git
a/core/src/test/resources/org/apache/iceberg/view/ValidViewMetadata.json
b/core/src/test/resources/org/apache/iceberg/view/ValidViewMetadata.json
index cf022c5a70..4b600d6f6b 100644
--- a/core/src/test/resources/org/apache/iceberg/view/ValidViewMetadata.json
+++ b/core/src/test/resources/org/apache/iceberg/view/ValidViewMetadata.json
@@ -2,7 +2,7 @@
"view-uuid": "fa6506c3-7681-40c8-86dc-e36561f83385",
"format-version": 1,
"location": "s3://bucket/test/location",
- "properties": {"some-key": "some-value"},
+ "properties": {"some-key": "some-value", "comment": "some-comment"},
"current-schema-id": 0,
"schemas": [
{
