This is an automated email from the ASF dual-hosted git repository.
amoghj pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg.git
The following commit(s) were added to refs/heads/main by this push:
new 8a16a41749 API: Fix typo in method comment of SortOrder and
SortOrderBuilder (#9816)
8a16a41749 is described below
commit 8a16a417492eb6ccb1895b4b6db3536ff2a8b67d
Author: dongwang <[email protected]>
AuthorDate: Tue Feb 27 23:20:08 2024 +0800
API: Fix typo in method comment of SortOrder and SortOrderBuilder (#9816)
---
api/src/main/java/org/apache/iceberg/SortOrder.java | 2 +-
api/src/main/java/org/apache/iceberg/SortOrderBuilder.java | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/api/src/main/java/org/apache/iceberg/SortOrder.java
b/api/src/main/java/org/apache/iceberg/SortOrder.java
index d0041cefc1..e98e05bd1e 100644
--- a/api/src/main/java/org/apache/iceberg/SortOrder.java
+++ b/api/src/main/java/org/apache/iceberg/SortOrder.java
@@ -212,7 +212,7 @@ public class SortOrder implements Serializable {
}
/**
- * Add an expression term to the sort, ascending with the given null order.
+ * Add an expression term to the sort, descending with the given null
order.
*
* @param term an expression term
* @param nullOrder a null order (first or last)
diff --git a/api/src/main/java/org/apache/iceberg/SortOrderBuilder.java
b/api/src/main/java/org/apache/iceberg/SortOrderBuilder.java
index 4dc8fa46e7..4a112e21c2 100644
--- a/api/src/main/java/org/apache/iceberg/SortOrderBuilder.java
+++ b/api/src/main/java/org/apache/iceberg/SortOrderBuilder.java
@@ -65,7 +65,7 @@ public interface SortOrderBuilder<R> {
R asc(Term term, NullOrder nullOrder);
/**
- * Add a field to the sort by field name, ascending with nulls first.
+ * Add a field to the sort by field name, descending with nulls first.
*
* @param name a field name
* @return this for method chaining
@@ -75,7 +75,7 @@ public interface SortOrderBuilder<R> {
}
/**
- * Add a field to the sort by field name, ascending with the given null
order.
+ * Add a field to the sort by field name, descending with the given null
order.
*
* @param name a field name
* @param nullOrder a null order (first or last)
@@ -86,7 +86,7 @@ public interface SortOrderBuilder<R> {
}
/**
- * Add an expression term to the sort, ascending with nulls first.
+ * Add an expression term to the sort, descending with nulls first.
*
* @param term an expression term
* @return this for method chaining
@@ -96,7 +96,7 @@ public interface SortOrderBuilder<R> {
}
/**
- * Add an expression term to the sort, ascending with the given null order.
+ * Add an expression term to the sort, descending with the given null order.
*
* @param term an expression term
* @param nullOrder a null order (first or last)