(iceberg-python) branch pyiceberg-0.6.x updated: minor fixes (#564)

[honahx]

This is an automated email from the ASF dual-hosted git repository.

honahx pushed a commit to branch pyiceberg-0.6.x
in repository https://gitbox.apache.org/repos/asf/iceberg-python.git


The following commit(s) were added to refs/heads/pyiceberg-0.6.x by this push:
     new 8a8c33ca minor fixes (#564)
8a8c33ca is described below

commit 8a8c33ca936d900282c4250dd4c2025f2ff90d1f
Author: Honah J <hon...@apache.org>
AuthorDate: Sat Mar 30 20:23:44 2024 -0700

    minor fixes (#564)
    
    Co-authored-by: Kevin Liu <kevinjq...@users.noreply.github.com>
---
 pyiceberg/table/__init__.py      | 10 ++++++----
 tests/integration/test_reads.py  |  1 -
 tests/integration/test_writes.py |  1 -
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/pyiceberg/table/__init__.py b/pyiceberg/table/__init__.py
index 55795db3..0f4e334d 100644
--- a/pyiceberg/table/__init__.py
+++ b/pyiceberg/table/__init__.py
@@ -1056,8 +1056,9 @@ class Table:
 
         _check_schema_compatible(self.schema(), other_schema=df.schema)
         # cast if the two schemas are compatible but not equal
-        if schema_to_pyarrow(self.schema()) != df.schema:
-            df = df.cast(schema_to_pyarrow(self.schema()))
+        table_arrow_schema = schema_to_pyarrow(self.schema())
+        if table_arrow_schema != df.schema:
+            df = df.cast(table_arrow_schema)
 
         merge = _MergingSnapshotProducer(operation=Operation.APPEND, 
table=self)
 
@@ -1096,8 +1097,9 @@ class Table:
 
         _check_schema_compatible(self.schema(), other_schema=df.schema)
         # cast if the two schemas are compatible but not equal
-        if schema_to_pyarrow(self.schema()) != df.schema:
-            df = df.cast(schema_to_pyarrow(self.schema()))
+        table_arrow_schema = schema_to_pyarrow(self.schema())
+        if table_arrow_schema != df.schema:
+            df = df.cast(table_arrow_schema)
 
         merge = _MergingSnapshotProducer(
             operation=Operation.OVERWRITE if self.current_snapshot() is not 
None else Operation.APPEND,
diff --git a/tests/integration/test_reads.py b/tests/integration/test_reads.py
index c03bc78a..ebebe3d5 100644
--- a/tests/integration/test_reads.py
+++ b/tests/integration/test_reads.py
@@ -230,7 +230,6 @@ def test_ray_nan_rewritten(catalog: Catalog) -> None:
 def test_ray_not_nan_count(catalog: Catalog) -> None:
     table_test_null_nan_rewritten = 
catalog.load_table("default.test_null_nan_rewritten")
     ray_dataset = 
table_test_null_nan_rewritten.scan(row_filter=NotNaN("col_numeric"), 
selected_fields=("idx",)).to_ray()
-    print(ray_dataset.take())
     assert ray_dataset.count() == 2
 
 
diff --git a/tests/integration/test_writes.py b/tests/integration/test_writes.py
index b138b2c7..887a5194 100644
--- a/tests/integration/test_writes.py
+++ b/tests/integration/test_writes.py
@@ -481,7 +481,6 @@ def test_write_parquet_other_properties(
     properties: Dict[str, Any],
     expected_kwargs: Dict[str, Any],
 ) -> None:
-    print(type(mocker))
     identifier = "default.test_write_parquet_other_properties"
 
     # The properties we test cannot be checked on the resulting Parquet file, 
so we spy on the ParquetWriter call instead