This is an automated email from the ASF dual-hosted git repository.
honahx pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-python.git
The following commit(s) were added to refs/heads/main by this push:
new 02a5ced4 Verify release quality of life improvements (#626)
02a5ced4 is described below
commit 02a5ced4c573463960565f73b143f43bb07edf62
Author: Kevin Liu <[email protected]>
AuthorDate: Sat Apr 20 16:19:44 2024 -0700
Verify release quality of life improvements (#626)
* fix integration test
* add instruction for verifying release
* use test-coverage
---
Makefile | 1 +
mkdocs/docs/how-to-release.md | 4 ++++
mkdocs/docs/verify-release.md | 10 ++++++----
3 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/Makefile b/Makefile
index 010410e3..54957bb9 100644
--- a/Makefile
+++ b/Makefile
@@ -63,6 +63,7 @@ test-coverage:
docker compose -f dev/docker-compose-integration.yml up -d
sh ./dev/run-azurite.sh
sh ./dev/run-gcs-server.sh
+ sleep 10
docker compose -f dev/docker-compose-integration.yml exec -T
spark-iceberg ipython ./provision.py
poetry run coverage run --source=pyiceberg/ -m pytest tests/
${PYTEST_ARGS}
poetry run coverage report -m --fail-under=90
diff --git a/mkdocs/docs/how-to-release.md b/mkdocs/docs/how-to-release.md
index a70c6784..2ecb6356 100644
--- a/mkdocs/docs/how-to-release.md
+++ b/mkdocs/docs/how-to-release.md
@@ -143,6 +143,10 @@ https://pypi.org/project/pyiceberg/$VERSION/
And can be installed using: pip3 install pyiceberg==$VERSION
+Instructions for verifying a release can be found here:
+
+* https://py.iceberg.apache.org/verify-release/
+
Please download, verify, and test.
Please vote in the next 72 hours.
diff --git a/mkdocs/docs/verify-release.md b/mkdocs/docs/verify-release.md
index a2b11890..9508abba 100644
--- a/mkdocs/docs/verify-release.md
+++ b/mkdocs/docs/verify-release.md
@@ -102,18 +102,20 @@ And then run the tests:
make test
```
-To run the full integration tests:
+To run the full test coverage:
```sh
-make test-s3
+make test-coverage
```
-This will include a Minio S3 container being spun up.
+This will spin up Docker containers to faciliate running test coverage.
# Cast the vote
Votes are cast by replying to the release candidate announcement email on the
dev mailing list with either `+1`, `0`, or `-1`. For example :
-> \[ \] +1 Release this as PyIceberg 0.3.0 \[ \] +0 \[ \] -1 Do not release
this because…
+> \[ \] +1 Release this as PyIceberg 0.3.0 <br>
+> \[ \] +0 <br>
+> \[ \] -1 Do not release this because… <br>
In addition to your vote, it’s customary to specify if your vote is binding or
non-binding. Only members of the Project Management Committee have formally
binding votes. If you’re unsure, you can specify that your vote is non-binding.
To read more about voting in the Apache framework, checkout the
[Voting](https://www.apache.org/foundation/voting.html) information page on the
Apache foundation’s website.
