This is an automated email from the ASF dual-hosted git repository.

amoghj pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/main by this push:
     new 48841a9120 Docs: Make compatibility example consistent (#10781)
48841a9120 is described below

commit 48841a91209552d761b54a0c6f6ed4a200d97d73
Author: emkornfield <[email protected]>
AuthorDate: Thu Jul 25 18:49:06 2024 -0700

    Docs: Make compatibility example consistent (#10781)
    
    Co-authored-by: Amogh Jahagirdar <[email protected]>
---
 site/docs/contribute.md | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/site/docs/contribute.md b/site/docs/contribute.md
index 17099c56bd..88a14e7153 100644
--- a/site/docs/contribute.md
+++ b/site/docs/contribute.md
@@ -196,6 +196,8 @@ public interface ManageSnapshots extends 
PendingUpdate<Snapshot> {
   // existing code...
 
   // adding this method introduces an API-breaking change
+  // since existing classes implementing ManageSnapshots
+  // will no longer compile.
   ManageSnapshots createBranch(String name);
 }
 ```
@@ -207,8 +209,8 @@ public class SnapshotManager implements ManageSnapshots {
   // existing code...
 
   @Override
-  public ManageSnapshots createBranch(String name, long snapshotId) {
-    updateSnapshotReferencesOperation().createBranch(name, snapshotId);
+  public ManageSnapshots createBranch(String name) {
+    updateSnapshotReferencesOperation().createBranch(name);
     return this;
   }
 }

Reply via email to