This is an automated email from the ASF dual-hosted git repository.
etudenhoefner pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg.git
The following commit(s) were added to refs/heads/main by this push:
new 8c85a5a7f1 Build: Suppress various build warnings (#10938)
8c85a5a7f1 is described below
commit 8c85a5a7f1539b39df65fbaac4c4c6d5d6b97eef
Author: Naveen Kumar <[email protected]>
AuthorDate: Thu Aug 15 18:21:14 2024 +0530
Build: Suppress various build warnings (#10938)
---
.../src/main/java/org/apache/iceberg/aliyun/oss/OSSInputStream.java | 2 +-
.../main/java/org/apache/iceberg/aliyun/oss/OSSOutputStream.java | 2 +-
api/src/main/java/org/apache/iceberg/Metrics.java | 2 ++
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java | 2 +-
aws/src/main/java/org/apache/iceberg/aws/s3/S3InputStream.java | 2 +-
aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java | 2 +-
.../main/java/org/apache/iceberg/azure/adlsv2/ADLSInputStream.java | 2 +-
.../main/java/org/apache/iceberg/azure/adlsv2/ADLSOutputStream.java | 2 +-
baseline.gradle | 6 ++----
core/src/main/java/org/apache/iceberg/hadoop/HadoopStreams.java | 4 ++--
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java | 2 +-
core/src/main/java/org/apache/iceberg/util/SerializationUtil.java | 2 +-
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSInputStream.java | 2 +-
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSOutputStream.java | 2 +-
.../java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java | 1 +
15 files changed, 18 insertions(+), 17 deletions(-)
diff --git
a/aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSInputStream.java
b/aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSInputStream.java
index b161bfcaf7..64e6259977 100644
--- a/aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSInputStream.java
+++ b/aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSInputStream.java
@@ -157,7 +157,7 @@ class OSSInputStream extends SeekableInputStream {
}
}
- @SuppressWarnings("checkstyle:NoFinalizer")
+ @SuppressWarnings({"checkstyle:NoFinalizer", "Finalize"})
@Override
protected void finalize() throws Throwable {
super.finalize();
diff --git
a/aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSOutputStream.java
b/aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSOutputStream.java
index 9644dab822..8c226d0012 100644
--- a/aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSOutputStream.java
+++ b/aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSOutputStream.java
@@ -165,7 +165,7 @@ public class OSSOutputStream extends PositionOutputStream {
}
}
- @SuppressWarnings("checkstyle:NoFinalizer")
+ @SuppressWarnings({"checkstyle:NoFinalizer", "Finalize"})
@Override
protected void finalize() throws Throwable {
super.finalize();
diff --git a/api/src/main/java/org/apache/iceberg/Metrics.java
b/api/src/main/java/org/apache/iceberg/Metrics.java
index 2f2cf89cda..d1a7da6d9d 100644
--- a/api/src/main/java/org/apache/iceberg/Metrics.java
+++ b/api/src/main/java/org/apache/iceberg/Metrics.java
@@ -179,6 +179,7 @@ public class Metrics implements Serializable {
* @throws IOException On serialization error
* @throws ClassNotFoundException If the class is not found
*/
+ @SuppressWarnings("DangerousJavaDeserialization")
private void readObject(ObjectInputStream in) throws IOException,
ClassNotFoundException {
rowCount = (Long) in.readObject();
columnSizes = (Map<Integer, Long>) in.readObject();
@@ -190,6 +191,7 @@ public class Metrics implements Serializable {
upperBounds = readByteBufferMap(in);
}
+ @SuppressWarnings("DangerousJavaDeserialization")
private static Map<Integer, ByteBuffer> readByteBufferMap(ObjectInputStream
in)
throws IOException, ClassNotFoundException {
int size = in.readInt();
diff --git a/aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
b/aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
index f7d2da5eb9..040d3012ca 100644
--- a/aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
+++ b/aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
@@ -412,7 +412,7 @@ public class S3FileIO implements CredentialSupplier,
DelegateFileIO, SupportsRec
}
}
- @SuppressWarnings("checkstyle:NoFinalizer")
+ @SuppressWarnings({"checkstyle:NoFinalizer", "Finalize"})
@Override
protected void finalize() throws Throwable {
super.finalize();
diff --git a/aws/src/main/java/org/apache/iceberg/aws/s3/S3InputStream.java
b/aws/src/main/java/org/apache/iceberg/aws/s3/S3InputStream.java
index f1d6c30a27..f442a0f04a 100644
--- a/aws/src/main/java/org/apache/iceberg/aws/s3/S3InputStream.java
+++ b/aws/src/main/java/org/apache/iceberg/aws/s3/S3InputStream.java
@@ -227,7 +227,7 @@ class S3InputStream extends SeekableInputStream implements
RangeReadable {
this.skipSize = skipSize;
}
- @SuppressWarnings("checkstyle:NoFinalizer")
+ @SuppressWarnings({"checkstyle:NoFinalizer", "Finalize"})
@Override
protected void finalize() throws Throwable {
super.finalize();
diff --git a/aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java
b/aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java
index 2a9275045d..ef0b4debf6 100644
--- a/aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java
+++ b/aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java
@@ -475,7 +475,7 @@ class S3OutputStream extends PositionOutputStream {
}
}
- @SuppressWarnings("checkstyle:NoFinalizer")
+ @SuppressWarnings({"checkstyle:NoFinalizer", "Finalize"})
@Override
protected void finalize() throws Throwable {
super.finalize();
diff --git
a/azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSInputStream.java
b/azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSInputStream.java
index 261ede62db..d9e1f93bea 100644
--- a/azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSInputStream.java
+++ b/azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSInputStream.java
@@ -190,7 +190,7 @@ class ADLSInputStream extends SeekableInputStream
implements RangeReadable {
}
}
- @SuppressWarnings("checkstyle:NoFinalizer")
+ @SuppressWarnings({"checkstyle:NoFinalizer", "Finalize"})
@Override
protected void finalize() throws Throwable {
super.finalize();
diff --git
a/azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSOutputStream.java
b/azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSOutputStream.java
index f38a408896..b507d5b541 100644
--- a/azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSOutputStream.java
+++ b/azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSOutputStream.java
@@ -110,7 +110,7 @@ class ADLSOutputStream extends PositionOutputStream {
}
}
- @SuppressWarnings("checkstyle:NoFinalizer")
+ @SuppressWarnings({"checkstyle:NoFinalizer", "Finalize"})
@Override
protected void finalize() throws Throwable {
super.finalize();
diff --git a/baseline.gradle b/baseline.gradle
index 42be6d8a24..486625636b 100644
--- a/baseline.gradle
+++ b/baseline.gradle
@@ -91,16 +91,14 @@ subprojects {
'-Xep:CollectionUndefinedEquality:ERROR',
// specific to Palantir - Uses name `log` but we use name `LOG`
'-Xep:ConsistentLoggerName:OFF',
- // TODO (https://github.com/apache/iceberg/issues/10853) this is a
recently added check. Figure out whether we adjust the code or suppress for good
- '-Xep:DangerousJavaDeserialization:WARN',
+ '-Xep:DangerousJavaDeserialization:ERROR',
'-Xep:DangerousThreadPoolExecutorUsage:OFF',
// subclasses are not equal
'-Xep:EqualsGetClass:OFF',
// specific to Palantir
'-Xep:FinalClass:OFF',
'-Xep:FormatStringAnnotation:ERROR',
- // TODO (https://github.com/apache/iceberg/issues/10855) this is a
recently added check. Figure out whether we adjust the code or suppress for good
- '-Xep:ImmutablesReferenceEquality:WARN',
+ '-Xep:ImmutablesReferenceEquality:ERROR',
'-Xep:IntLongMath:ERROR',
// prefer method references over lambdas
'-Xep:LambdaMethodReference:ERROR',
diff --git a/core/src/main/java/org/apache/iceberg/hadoop/HadoopStreams.java
b/core/src/main/java/org/apache/iceberg/hadoop/HadoopStreams.java
index c817b1d90a..6a48b14c22 100644
--- a/core/src/main/java/org/apache/iceberg/hadoop/HadoopStreams.java
+++ b/core/src/main/java/org/apache/iceberg/hadoop/HadoopStreams.java
@@ -122,7 +122,7 @@ public class HadoopStreams {
return stream.read(b, off, len);
}
- @SuppressWarnings("checkstyle:NoFinalizer")
+ @SuppressWarnings({"checkstyle:NoFinalizer", "Finalize"})
@Override
protected void finalize() throws Throwable {
super.finalize();
@@ -195,7 +195,7 @@ public class HadoopStreams {
}
}
- @SuppressWarnings("checkstyle:NoFinalizer")
+ @SuppressWarnings({"checkstyle:NoFinalizer", "Finalize"})
@Override
protected void finalize() throws Throwable {
super.finalize();
diff --git a/core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java
b/core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java
index e5c7c51631..b5232960dc 100644
--- a/core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java
+++ b/core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java
@@ -240,7 +240,7 @@ public class ResolvingFileIO implements HadoopConfigurable,
DelegateFileIO {
return null;
}
- @SuppressWarnings("checkstyle:NoFinalizer")
+ @SuppressWarnings({"checkstyle:NoFinalizer", "Finalize"})
@Override
protected void finalize() throws Throwable {
super.finalize();
diff --git a/core/src/main/java/org/apache/iceberg/util/SerializationUtil.java
b/core/src/main/java/org/apache/iceberg/util/SerializationUtil.java
index ddba0b0bbe..216f55eae3 100644
--- a/core/src/main/java/org/apache/iceberg/util/SerializationUtil.java
+++ b/core/src/main/java/org/apache/iceberg/util/SerializationUtil.java
@@ -69,7 +69,7 @@ public class SerializationUtil {
}
}
- @SuppressWarnings("unchecked")
+ @SuppressWarnings({"DangerousJavaDeserialization", "unchecked"})
public static <T> T deserializeFromBytes(byte[] bytes) {
if (bytes == null) {
return null;
diff --git a/gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSInputStream.java
b/gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSInputStream.java
index fea51d50cf..4483b02336 100644
--- a/gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSInputStream.java
+++ b/gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSInputStream.java
@@ -186,7 +186,7 @@ class GCSInputStream extends SeekableInputStream implements
RangeReadable {
}
}
- @SuppressWarnings("checkstyle:NoFinalizer")
+ @SuppressWarnings({"checkstyle:NoFinalizer", "Finalize"})
@Override
protected void finalize() throws Throwable {
super.finalize();
diff --git a/gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSOutputStream.java
b/gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSOutputStream.java
index bcd6099ac9..e52a163882 100644
--- a/gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSOutputStream.java
+++ b/gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSOutputStream.java
@@ -130,7 +130,7 @@ class GCSOutputStream extends PositionOutputStream {
stream.close();
}
- @SuppressWarnings("checkstyle:NoFinalizer")
+ @SuppressWarnings({"checkstyle:NoFinalizer", "Finalize"})
@Override
protected void finalize() throws Throwable {
super.finalize();
diff --git
a/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
b/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
index da2735774c..8b9cd3d3d4 100644
---
a/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
+++
b/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
@@ -508,6 +508,7 @@ public class HiveIcebergOutputCommitter extends
OutputCommitter {
LOG.debug("Iceberg committed file is created {}", fileForCommit);
}
+ @SuppressWarnings("DangerousJavaDeserialization")
private static DataFile[] readFileForCommit(String fileForCommitLocation,
FileIO io) {
try (ObjectInputStream ois =
new
ObjectInputStream(io.newInputFile(fileForCommitLocation).newStream())) {
