This is an automated email from the ASF dual-hosted git repository.
etudenhoefner pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg.git
The following commit(s) were added to refs/heads/main by this push:
new 208ab20dc9 Arrow: Remove unused readers (#11276)
208ab20dc9 is described below
commit 208ab20dc9ab8bcab3ee525d0ddaba80eeae7609
Author: Wing Yew Poon <[email protected]>
AuthorDate: Tue Oct 8 00:21:50 2024 -0700
Arrow: Remove unused readers (#11276)
---
...orizedDictionaryEncodedParquetValuesReader.java | 38 --------
.../VectorizedParquetDefinitionLevelReader.java | 108 ---------------------
2 files changed, 146 deletions(-)
diff --git
a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedDictionaryEncodedParquetValuesReader.java
b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedDictionaryEncodedParquetValuesReader.java
index 55f1d3fd79..21670f6b2b 100644
---
a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedDictionaryEncodedParquetValuesReader.java
+++
b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedDictionaryEncodedParquetValuesReader.java
@@ -22,7 +22,6 @@ import java.nio.ByteBuffer;
import java.nio.ByteOrder;
import org.apache.arrow.vector.BaseVariableWidthVector;
import org.apache.arrow.vector.BitVectorHelper;
-import org.apache.arrow.vector.DecimalVector;
import org.apache.arrow.vector.FieldVector;
import org.apache.arrow.vector.FixedSizeBinaryVector;
import org.apache.arrow.vector.IntVector;
@@ -151,15 +150,6 @@ public class VectorizedDictionaryEncodedParquetValuesReader
}
}
- class FixedLengthDecimalDictEncodedReader extends BaseDictEncodedReader {
- @Override
- protected void nextVal(
- FieldVector vector, Dictionary dict, int idx, int currentVal, int
typeWidth) {
- byte[] bytes = dict.decodeToBinary(currentVal).getBytesUnsafe();
- DecimalVectorUtil.setBigEndian((DecimalVector) vector, idx, bytes);
- }
- }
-
class VarWidthBinaryDictEncodedReader extends BaseDictEncodedReader {
@Override
protected void nextVal(
@@ -174,22 +164,6 @@ public class VectorizedDictionaryEncodedParquetValuesReader
}
}
- class IntBackedDecimalDictEncodedReader extends BaseDictEncodedReader {
- @Override
- protected void nextVal(
- FieldVector vector, Dictionary dict, int idx, int currentVal, int
typeWidth) {
- ((DecimalVector) vector).set(idx, dict.decodeToInt(currentVal));
- }
- }
-
- class LongBackedDecimalDictEncodedReader extends BaseDictEncodedReader {
- @Override
- protected void nextVal(
- FieldVector vector, Dictionary dict, int idx, int currentVal, int
typeWidth) {
- ((DecimalVector) vector).set(idx, dict.decodeToLong(currentVal));
- }
- }
-
class FixedSizeBinaryDictEncodedReader extends BaseDictEncodedReader {
@Override
protected void nextVal(
@@ -233,22 +207,10 @@ public class
VectorizedDictionaryEncodedParquetValuesReader
return new FixedWidthBinaryDictEncodedReader();
}
- public FixedLengthDecimalDictEncodedReader
fixedLengthDecimalDictEncodedReader() {
- return new FixedLengthDecimalDictEncodedReader();
- }
-
public VarWidthBinaryDictEncodedReader varWidthBinaryDictEncodedReader() {
return new VarWidthBinaryDictEncodedReader();
}
- public IntBackedDecimalDictEncodedReader intBackedDecimalDictEncodedReader()
{
- return new IntBackedDecimalDictEncodedReader();
- }
-
- public LongBackedDecimalDictEncodedReader
longBackedDecimalDictEncodedReader() {
- return new LongBackedDecimalDictEncodedReader();
- }
-
public FixedSizeBinaryDictEncodedReader fixedSizeBinaryDictEncodedReader() {
return new FixedSizeBinaryDictEncodedReader();
}
diff --git
a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java
b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java
index 20d7f80497..2d2412c550 100644
---
a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java
+++
b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java
@@ -24,7 +24,6 @@ import org.apache.arrow.memory.ArrowBuf;
import org.apache.arrow.vector.BaseVariableWidthVector;
import org.apache.arrow.vector.BitVector;
import org.apache.arrow.vector.BitVectorHelper;
-import org.apache.arrow.vector.DecimalVector;
import org.apache.arrow.vector.FieldVector;
import org.apache.arrow.vector.FixedSizeBinaryVector;
import org.apache.arrow.vector.IntVector;
@@ -532,39 +531,6 @@ public final class VectorizedParquetDefinitionLevelReader
}
}
- class FixedLengthDecimalReader extends BaseReader {
- @Override
- protected void nextVal(
- FieldVector vector,
- int idx,
- ValuesAsBytesReader valuesReader,
- int typeWidth,
- byte[] byteArray) {
- valuesReader.getBuffer(typeWidth).get(byteArray, 0, typeWidth);
- DecimalVectorUtil.setBigEndian((DecimalVector) vector, idx, byteArray);
- }
-
- @Override
- protected void nextDictEncodedVal(
- FieldVector vector,
- int idx,
- VectorizedDictionaryEncodedParquetValuesReader reader,
- int numValuesToRead,
- Dictionary dict,
- NullabilityHolder nullabilityHolder,
- int typeWidth,
- Mode mode) {
- if (Mode.RLE.equals(mode)) {
- reader
- .fixedLengthDecimalDictEncodedReader()
- .nextBatch(vector, idx, numValuesToRead, dict, nullabilityHolder,
typeWidth);
- } else if (Mode.PACKED.equals(mode)) {
- byte[] bytes =
dict.decodeToBinary(reader.readInteger()).getBytesUnsafe();
- DecimalVectorUtil.setBigEndian((DecimalVector) vector, idx, bytes);
- }
- }
- }
-
class FixedSizeBinaryReader extends BaseReader {
@Override
protected void nextVal(
@@ -645,68 +611,6 @@ public final class VectorizedParquetDefinitionLevelReader
}
}
- class IntBackedDecimalReader extends BaseReader {
- @Override
- protected void nextVal(
- FieldVector vector,
- int idx,
- ValuesAsBytesReader valuesReader,
- int typeWidth,
- byte[] byteArray) {
- ((DecimalVector) vector).set(idx,
valuesReader.getBuffer(Integer.BYTES).getInt());
- }
-
- @Override
- protected void nextDictEncodedVal(
- FieldVector vector,
- int idx,
- VectorizedDictionaryEncodedParquetValuesReader reader,
- int numValuesToRead,
- Dictionary dict,
- NullabilityHolder nullabilityHolder,
- int typeWidth,
- Mode mode) {
- if (Mode.RLE.equals(mode)) {
- reader
- .intBackedDecimalDictEncodedReader()
- .nextBatch(vector, idx, numValuesToRead, dict, nullabilityHolder,
typeWidth);
- } else if (Mode.PACKED.equals(mode)) {
- ((DecimalVector) vector).set(idx,
dict.decodeToInt(reader.readInteger()));
- }
- }
- }
-
- class LongBackedDecimalReader extends BaseReader {
- @Override
- protected void nextVal(
- FieldVector vector,
- int idx,
- ValuesAsBytesReader valuesReader,
- int typeWidth,
- byte[] byteArray) {
- ((DecimalVector) vector).set(idx,
valuesReader.getBuffer(Long.BYTES).getLong());
- }
-
- @Override
- protected void nextDictEncodedVal(
- FieldVector vector,
- int idx,
- VectorizedDictionaryEncodedParquetValuesReader reader,
- int numValuesToRead,
- Dictionary dict,
- NullabilityHolder nullabilityHolder,
- int typeWidth,
- Mode mode) {
- if (Mode.RLE.equals(mode)) {
- reader
- .longBackedDecimalDictEncodedReader()
- .nextBatch(vector, idx, numValuesToRead, dict, nullabilityHolder,
typeWidth);
- } else if (Mode.PACKED.equals(mode)) {
- ((DecimalVector) vector).set(idx,
dict.decodeToLong(reader.readInteger()));
- }
- }
- }
-
class BooleanReader extends BaseReader {
@Override
protected void nextVal(
@@ -832,10 +736,6 @@ public final class VectorizedParquetDefinitionLevelReader
return new FixedWidthBinaryReader();
}
- FixedLengthDecimalReader fixedLengthDecimalReader() {
- return new FixedLengthDecimalReader();
- }
-
FixedSizeBinaryReader fixedSizeBinaryReader() {
return new FixedSizeBinaryReader();
}
@@ -844,14 +744,6 @@ public final class VectorizedParquetDefinitionLevelReader
return new VarWidthReader();
}
- IntBackedDecimalReader intBackedDecimalReader() {
- return new IntBackedDecimalReader();
- }
-
- LongBackedDecimalReader longBackedDecimalReader() {
- return new LongBackedDecimalReader();
- }
-
BooleanReader booleanReader() {
return new BooleanReader();
}
